Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuking mesh coordinates #238

Open
gthyagi opened this issue Aug 29, 2024 · 1 comment
Open

Nuking mesh coordinates #238

gthyagi opened this issue Aug 29, 2024 · 1 comment
Assignees

Comments

@gthyagi
Copy link
Contributor

gthyagi commented Aug 29, 2024

Hi @lmoresi,

Each time we create a mesh by calling uw.discretisation.Mesh, we execute self.nuke_coords_and_rebuild(), regardless of whether the mesh is deformed or undeformed. Is this necessary?

self.nuke_coords_and_rebuild()

In my case, I'm simply creating the mesh.msh and mesh.h5 files for the sphere, so I'm wondering why it needs to go through the nuking process.

@lmoresi
Copy link
Member

lmoresi commented Aug 29, 2024

I suppose that if you are just converting a .msh to a .h5, then this is not really necessary. In fact we already do this because we convert any gmsh file into a dmplex and save as h5 before building the mesh.

So if you are just converting files to store, maybe just use that strategy. It's in the _from_gmsh() function in the discretisation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants