Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render places where tree was, but is missing (and not a stump) and there is no tree in it's place #98

Open
3 tasks
Gregory108 opened this issue Aug 28, 2024 · 2 comments
Labels
enhancement New feature or request UX

Comments

@Gregory108
Copy link
Collaborator

state=gone category now holds 2 meanings:

  1. error input, tests, and other irrelevant data points, aka "garbage"
  2. tree was there, but was removed (including a stump), but no tree was planted in its stead

The later should be displayed, because we collect those empty places as they are actionable. I suggest black semi-transparent square (because, mostly those are dirt squares))

However, when something, eventually, will be planted in this place, it should stop being visible, because the empty place it was filled.
(But, of cause, the story of a tree that was there should not be deleted)

  • add graphic element for points state=gone points
  • clean production DB from "garbage" (regularly)
  • add "do not show if there is a tree that replaced it" logic
@Gregory108 Gregory108 added enhancement New feature or request UX labels Aug 28, 2024
@Gregory108 Gregory108 changed the title Reder places where tree was, but is missing (and not a stump) and there is no tree in it's place Render places where tree was, but is missing (and not a stump) and there is no tree in it's place Aug 28, 2024
@umonkey
Copy link
Owner

umonkey commented Aug 31, 2024

@Gregory108 you can actually see "gone" trees if you type "all" in the search bar. Displaying them by default could be a little misleading, as you expect a map of trees, not a map of places where trees once were, and colors cannot be intuitive, so this puts extra pressure on new users.

@umonkey
Copy link
Owner

umonkey commented Aug 31, 2024

@Gregory108 another thing with rendering "gone" is that they are (hopefully) replaced with real trees at some point, and would overlap on the map. So we'll probably need to add a new status "replaced", to finally hide the dot, as soon as at least one tree gets replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UX
Projects
None yet
Development

No branches or pull requests

2 participants