Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] external caused a syntax error when encountering package names containing "." #1483

Open
Jinbao1001 opened this issue Aug 8, 2024 · 0 comments
Open

[BUG] external caused a syntax error when encountering package names containing "." #1483

Jinbao1001 opened this issue Aug 8, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Jinbao1001
Copy link
Member

such as @svgdotjs/svg.js

generate to module.exports = (typeof globalThis !== 'undefined' ? globalThis : self).@svgdotjs/svg.js

caused by resolve/mod.rs fn get_external_target_from_global_obj

webpack handles this by configuring a 'subtract' array instead of checking for the '.' character.

https://github.com/webpack/webpack.js.org/pull/1348/files
@sorrycc sorrycc added bug Something isn't working good first issue Good for newcomers labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sorrycc @xusd320 @Jinbao1001