Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onSearchButtonPress only triggered after text is typed in #184

Open
reinvanimschoot opened this issue Sep 11, 2020 · 0 comments
Open

onSearchButtonPress only triggered after text is typed in #184

reinvanimschoot opened this issue Sep 11, 2020 · 0 comments

Comments

@reinvanimschoot
Copy link

Hi guys

This seems like a small issue but I still would love to bring some attention to it.

The onSearchButtonPress callback is only called when some text is actually typed in the searchbar.
For consistency's sake, I would love it if, even if the input is empty, the callback would still be called.

In my case, the callback is a keyboard dismissal. To give an example, in Instagram, if you press the search button without any input, it also just dismisses the keyboard. So I'm hoping to get the same kind of consistency.

Thanks for the great component!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant