Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front camera #68

Merged
merged 6 commits into from
Jan 9, 2025
Merged

Front camera #68

merged 6 commits into from
Jan 9, 2025

Conversation

john-rocky
Copy link
Contributor

@john-rocky john-rocky commented Nov 30, 2024

This change enables the front camera.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Added front-camera support and improved camera switching functionality. 📸

📊 Key Changes

  • 📂 Updated Info.plist version to 83.
  • 🎥 Enhanced camera device selection to support front and back cameras dynamically.
  • 🔄 Added front-to-back and back-to-front camera switching, allowing seamless transitions.
  • 🪞 Ensured correct orientation and mirroring for front-camera previews and photos.
  • 🖼️ Included a new system image asset (camera.rotate) for UI interactions.

🎯 Purpose & Impact

  • Improved Camera Functionality: Users can now toggle between front and back cameras easily.
  • Better User Experience: Front camera support adds flexibility for tasks like selfies or live streaming.
  • Accuracy in Media Output: Proper mirroring ensures photos and videos captured with the front camera appear natural.
  • Enhanced UI: The new UI element improves accessibility and usability for camera-switching.

📱 This update is a game-changer for creating a more dynamic and user-friendly iOS app experience! 🚀

@UltralyticsAssistant UltralyticsAssistant added detect Object Detection issues, PR's documentation Improvements or additions to documentation enhancement New feature or request labels Nov 30, 2024
@UltralyticsAssistant
Copy link
Member

👋 Hello @john-rocky, thank you for submitting a 🚀 PR to the ultralytics/yolo-ios-app repository! To help us review and integrate your contribution smoothly, here’s a quick checklist for you:

  • Define a Purpose: Please make sure that your PR description clearly explains the purpose of the changes introduced. Linking any related issues can be helpful, as it provides more context for the reviewers.
  • Provide a Clear Diff: We noticed the substantial changes in files such as VideoCapture.swift, ViewController.swift, and the addition of front-camera functionality. If possible, include a brief summary of the specific technical modifications and their intent (e.g., rationale for switching APIs or updating deployment targets).
  • Minimum Reproducible Example (MRE): If this is addressing a bug or compatibility issue, kindly provide a minimum reproducible example (if not already included) so the team can test your changes more effectively.
  • Ensure CI Passes: Our CI pipeline (GitHub Actions Badge) is designed to verify the quality of contributions. Be sure to monitor your build status, resolve failing checks, and verify passing tests.
  • Documentation Updates: For changes like transitioning from YOLOv8 to YOLO11 or adding front-camera support, please ensure corresponding updates to the project documentation. This will help keep everything in sync and improve user clarity.
  • Sign the CLA: If you haven’t already signed our Contributor License Agreement (CLA), please do so. To sign, leave a comment like "I have read the CLA Document and I sign the CLA" in this PR.

We truly value your efforts to improve the app 🚀! An Ultralytics engineer will review this PR shortly and provide additional feedback as needed. For now, feel free to refer to our Contributing Guide for further details on our workflow.

Thank you again for your contribution, and let us know if you have any questions! 🎉

@asabri97 asabri97 merged commit 5a8f818 into ultralytics:main Jan 9, 2025
2 checks passed
@UltralyticsAssistant
Copy link
Member

✨ Your PR has been merged! Huge thanks to @john-rocky for leading the charge and to @asabri97 for your valuable contributions! 📸

This update is a leap forward, bringing seamless front-camera support and dynamic switching to life. Your work elevates the user experience—making every photo, live stream, and video more intuitive and natural.

As Leonardo da Vinci once said, “Details make perfection, and perfection is not a detail.” Your attention to detail here has undoubtedly perfected our app.

Thank you both for making a difference—your efforts will brighten countless user interactions! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detect Object Detection issues, PR's documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants