New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SolrFields.SOLR_COLLECTION vs SolrFields.COLLECTION, same string value #316

Open

vkush opened this issue Aug 2, 2024 · 0 comments

vkush commented Aug 2, 2024

Investigating issue #315 I have found, that variables "SOLR_COLLECTION" and "COLLECTION" represent the same property "collection":

webarchive-discovery/warc-indexer/src/main/java/uk/bl/wa/solr/SolrFields.java

Line 67 in 13595be

    
           public static final String SOLR_COLLECTION = "collection"; // Top-level collection

and

webarchive-discovery/warc-indexer/src/main/java/uk/bl/wa/solr/SolrFields.java

Line 153 in 13595be

public static final String COLLECTION = "collection";

Is it correct so? Maybe yes, because I see, that variable SolrField.SOLR_COLLECTION is currently used only in one place in Annotator.java:
https://github.com/search?q=repo%3Aukwa%2Fwebarchive-discovery%20SOLR_COLLECTION&type=code
And SolrField.COLLECTION is used here:
https://github.com/search?q=repo%3Aukwa%2Fwebarchive-discovery+SolrFields.COLLECTION&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment