Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable url_norm by default #285

Open
anjackson opened this issue Mar 30, 2022 · 2 comments
Open

Enable url_norm by default #285

anjackson opened this issue Mar 30, 2022 · 2 comments
Assignees

Comments

@anjackson
Copy link
Contributor

In testing it seems the default config does not enable the url_norm field, which SolrWayback needs. It's a pretty useful field anyway, so I suggest we switch it on by default.

@anjackson anjackson self-assigned this Mar 30, 2022
@anjackson
Copy link
Contributor Author

It seems that the current logic is that the normalised URL is stored if we configure the links to be stored in normalised form:

addNormalisedURL = conf.hasPath(HtmlFeatureParser.CONF_LINKS_NORMALISE) ?
conf.getBoolean(HtmlFeatureParser.CONF_LINKS_NORMALISE) :
HtmlFeatureParser.DEFAULT_LINKS_NORMALISE;

It's not immediately obvious to me why these two separate fields are being coupled in this way, but the upshot is that implementing this ticket means changing this line:

Given the two fields are coupled, does this mean we need to enable resource-level link extraction for this to be any use? I think not?

@anjackson
Copy link
Contributor Author

i.e. is

                "linked" : {
                    "normalise" : true,
                    "resources" : false,
                    "hosts" : true,
                    "domains" : true,
                    "images" : true
                },

a valid configuration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant