Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit aa1617e creates issues when creating a new email where context is also set. #443

Open
gabn88 opened this issue Jun 14, 2023 · 2 comments

Comments

@gabn88
Copy link
Contributor

gabn88 commented Jun 14, 2023

In my case I do always set the context, but I also leave template sometimes empty.

Then the "fix" in commit aa1617e creates an error:

AttributeError post_office.tasks.send_queued_mail
'NoneType' object has no attribute 'subject'


on line 
            subject = engine.from_string(self.template.subject).render(self.context)

@selwin
Copy link
Collaborator

selwin commented Jun 15, 2023

Mind opening a PR for this?

@gabn88
Copy link
Contributor Author

gabn88 commented Sep 25, 2023

@selwin Sorry for the slow response. Using an older version for now. This is however still a problem in the latest master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants