Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fatal Javascript Error when clicking on Notification #6

Open
mountainash opened this issue Feb 15, 2020 · 2 comments
Open

Fatal Javascript Error when clicking on Notification #6

mountainash opened this issue Feb 15, 2020 · 2 comments

Comments

@mountainash
Copy link 

A JavaScript error occurred in the main process

Uncaught Exception:
ReferenceError: notificationIndex is not defined
    at Notification.notification.on (/Users/rowanw/Sites/test/github/MixCloud-Play/dist/mac/MixCloud Play.app/Contents/Resources/app.asar/build/main.js:197:60)
    at emitOne (events.js:116:13)
    at Notification.emit (events.js:211:7)

When click on the macOS notification (alert) a dialogue with the above error shows - often the app will then exit (not always).

/assign @mountainash
/label ~Doing
mountainash added a commit to mountainash/Mixcloud-Play that referenced this issue Feb 16, 2020
@mountainash
Removed Preferences - didn't work anyway
4349682 
 - With Prefernce gone - all React & mobx wasn't needed (.app now builds and loads faster)
 - Added eslist vscode settings to stop "constant" warnings

Fixed notification onclick errors. Closes uffou#6
@mountainash
Copy link
Author

I've fixed this in my Fork and will raise a MR soon.

@mountainash
Copy link
Author

I've fixed this in my Fork and will raise a MR soon.

Done in #8 - ready for the Maintainer to review/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mountainash