Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup with translation can be broken by styles of page where it is open #92

Open
davidyuk opened this issue Feb 28, 2021 · 0 comments
Open

Comments

@davidyuk
Copy link
Contributor

Describe the bug
Popup with translation in some cases can be broken by the styles of the page where it is open.

To Reproduce

  1. Go to example.com
  2. Select some text to translate
  3. See a popup with extra padding like on the screenshots below

Expected behavior
A popup without extra paddings.

Screenshots
Screenshot 2021-02-28 at 20 18 41

Version:

  • Safari 14.0.3
  • Polyglot 3.3.0
  • macOS 11.2.1

Additional context
Instead of the current styles isolation approach (polyglot namespace and !important) I'm proposing to put popups into a shadow DOM (part of Web Components API) this should allow completely isolate styles of extension's popups from the styles of the opened page. Web Components seems to be well-supported by the latest versions of Safari.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants