Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test coverage upload #96

Closed
KyleJune opened this issue Aug 1, 2024 · 1 comment
Closed

Fix test coverage upload #96

KyleJune opened this issue Aug 1, 2024 · 1 comment

Comments

@KyleJune
Copy link
Member

KyleJune commented Aug 1, 2024

My previous PR #95 added a few test files that had no tests in them. despite having fail_ci_if_error set to true, it is failing with an unknown error.

https://app.codecov.io/github/udibo/react-app/commit/3b82a7fada671228654a6f8dfeb60b8322e54d74

I suspect it is related to the files not actually having any test cases but I'm not sure. The deno coverage command seems to be able to handle the generated coverage just fine but maybe there is an issue with the generated cov files that codecov uses.

image

@KyleJune KyleJune changed the title Fix test coverage upload. Fix test coverage upload Aug 1, 2024
@KyleJune
Copy link
Member Author

KyleJune commented Aug 1, 2024

Nevermind, it looks like maybe the issue was on codecov's side because that link now shows that the upload was successful. It was showing an unknown error previously. I'm guessing they retried processing it and it worked.

@KyleJune KyleJune closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant