From 49f828e2ac3431134fa03fe035e81590d779f9cc Mon Sep 17 00:00:00 2001 From: Joe Anderson Date: Fri, 28 Jun 2024 10:22:10 +0100 Subject: [PATCH 1/4] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4403362f49..77aff7a513 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,2 +1,21 @@ -- [ ] added [changesets](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md) -- [ ] updated [components changelog](https://github.com/udecode/plate/blob/main/apps/www/content/docs/components/changelog.mdx) + + +- [ ] `yarn test` passes +- [ ] `yarn typecheck` passes +- [ ] Ran `yarn lint:fix` +- [ ] Added a changeset (if required) +- [ ] Updated the component changelog (if required) From fd1c8ab77b2b49bef9d4e26323a2dd186024f92b Mon Sep 17 00:00:00 2001 From: Joe Anderson Date: Fri, 28 Jun 2024 10:25:46 +0100 Subject: [PATCH 2/4] Can't forget about `yarn brl` --- .github/PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 77aff7a513..e531c684ea 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -17,5 +17,6 @@ you changed. See `apps/www/content/docs/components/changelog.mdx`. - [ ] `yarn test` passes - [ ] `yarn typecheck` passes - [ ] Ran `yarn lint:fix` +- [ ] Ran `yarn brl` (if adding, removing or deleting source files) - [ ] Added a changeset (if required) - [ ] Updated the component changelog (if required) From 30379751f0ff8ace243e0290d1713013d96686c6 Mon Sep 17 00:00:00 2001 From: Joe Anderson Date: Fri, 28 Jun 2024 10:27:37 +0100 Subject: [PATCH 3/4] Typo --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e531c684ea..0bbfb80160 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -17,6 +17,6 @@ you changed. See `apps/www/content/docs/components/changelog.mdx`. - [ ] `yarn test` passes - [ ] `yarn typecheck` passes - [ ] Ran `yarn lint:fix` -- [ ] Ran `yarn brl` (if adding, removing or deleting source files) +- [ ] Ran `yarn brl` (if adding, renaming or deleting source files) - [ ] Added a changeset (if required) - [ ] Updated the component changelog (if required) From 9f902a4dad8558c24c10faa60a91747ea06d6c43 Mon Sep 17 00:00:00 2001 From: Ziad Beyens Date: Fri, 28 Jun 2024 11:38:12 +0200 Subject: [PATCH 4/4] typo --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0bbfb80160..2693353234 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -5,7 +5,7 @@ merged as soon as possible. Adding a changeset using `yarn changeset` is required if you've modified a source file in `packages`. Please be brief and descriptive. For breaking -changes, use a major changset. For new features, use a minor changeset. For +changes, use a major changeset. For new features, use a minor changeset. For bug fixes, use a patch changeset. Changes to component files inside `apps/www/src/registry` don't require a