Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Shell Notifications have too bright onClick color #4082

Closed
Feichtmeier opened this issue Apr 21, 2024 · 5 comments · Fixed by #4181
Closed

Dark Shell Notifications have too bright onClick color #4082

Feichtmeier opened this issue Apr 21, 2024 · 5 comments · Fixed by #4181

Comments

@Feichtmeier
Copy link
Member

I have forgotten how the css property is named, but when one clicks the notifications in the dark shell they are super bright

grafik

Plus I think the border radius is too small

CC @3v1n0

@ochi12
Copy link
Contributor

ochi12 commented Dec 1, 2024

I will try to look on this

@ochi12
Copy link
Contributor

ochi12 commented Dec 1, 2024

One problem tho as I always say I'm a complete newbie. this is under gnome-shell/ right?

Modifying border-radius and the ligthen function :&active should solve this.

.notification-banner {
  min-height: $notification_banner_height;
  width: $notification_banner_width;
  box-shadow: 0 2px 4px 2px $shadow_color;
  margin: $base_margin;
  border-radius: $modal_radius;
  background-color: $bg_color; // Yaru change: use bg_color for better contrast with buttons

  @if $contrast == 'high' {
    @include draw_hc_inset();
  }

  &:hover {
    // Yaru change: ↑↑↑
    background-color: if($variant =='light', darken($bg_color, 2%), lighten($bg_color, 2%));
  }

  &:active {
    // Yaru change: ↑↑↑
    background-color: if($variant =='light', darken($bg_color, 4%), lighten($bg_color, 4%));
  }

  // Yaru: make notifications more visible on different headerbars:
  &,
  &:hover,
  &:focus,
  &:active {
    box-shadow: 0 0 4px 2px rgba(0, 0, 0, 0.1);
    border: 1px solid $borders_color;
  }
}

build from modified source:

the ninja installation work I looked at the changes in /usr/share/gnome-shell and confirmed that the 60px border radius I tested is in there but the popup notification is still in the default radius

manually edited gnome-shell.css:

I also tried changing gnome-shell.css in /usr/share/themes/Yaru/Yaru-dark ... log out login ... no luck.

I'm not familiar into css theming in Yaru at all so maybe there are necessary files to be edited too? 🤷🏽

@ochi12
Copy link
Contributor

ochi12 commented Dec 2, 2024

@Feichtmeier
Why is the gnome-shell-theme.gresource file not being overwritten? the ninja installation doesn't even install it.
looked upon gnome-shell/theme/Yaru still no gnome-shell-theme.gresource installed

Did I miss something?
I tried to extract the gnome-shell.css and other variants in that gresource file and looked at the .notification-banner entry but it is still the default 6 px.

I followed the build and install steps

$ meson _build
$ ninja -C _build
$ ninja -C _build install

even tried to uninstall yaru-theme-gnome-shell then repeated the above commands, looked upon gnome-shell/theme/Yaru still no gnome-shell-theme.gresource installed

Did I miss something?

@Feichtmeier
Copy link
Member Author

@Feichtmeier
Why is the gnome-shell-theme.gresource file not being overwritten? the ninja installation doesn't even install it.
looked upon gnome-shell/theme/Yaru still no gnome-shell-theme.gresource installed

Did I miss something?
I tried to extract the gnome-shell.css and other variants in that gresource file and looked at the .notification-banner entry but it is still the default 6 px.

I followed the build and install steps

$ meson _build
$ ninja -C _build
$ ninja -C _build install

even tried to uninstall yaru-theme-gnome-shell then repeated the above commands, looked upon gnome-shell/theme/Yaru still no gnome-shell-theme.gresource installed

Did I miss something?

I'm a little out of the loop but the last time I edited the notifications all I needed to change was scss code
Forwarding this to @3v1n0 and @Muqtxdir

@ochi12
Copy link
Contributor

ochi12 commented Dec 2, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants