From 52233fd39e16cd708b0e4a96bd53ff39e32e6096 Mon Sep 17 00:00:00 2001 From: Daniel van Vugt Date: Fri, 1 Mar 2024 12:17:57 +0800 Subject: [PATCH] gnome-shell: Don't give login-dialog another background-color (#4050) Its parent `lockDialogGroup` has exactly the same background-color set in the same file. Giving them both the same wasted render time on overdraw, and caused multi-layer blending artifacts (slight flickering of the grey background) when the login dialog fades in/out. While the flicker can also be fixed using `set_offscreen_redirect`, there's no point adding that overhead when the extra layer doesn't need to be painted. Removing it halves the average render time of the login animation. Closes: #4048 Copied-from: https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/d09509b2cbce --- gnome-shell/src/gnome-shell-sass/widgets/_login-lock.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/gnome-shell/src/gnome-shell-sass/widgets/_login-lock.scss b/gnome-shell/src/gnome-shell-sass/widgets/_login-lock.scss index 5d29e240d7..6be38f1fb2 100644 --- a/gnome-shell/src/gnome-shell-sass/widgets/_login-lock.scss +++ b/gnome-shell/src/gnome-shell-sass/widgets/_login-lock.scss @@ -14,7 +14,6 @@ $_gdm_dialog_width: 23em; /* Login Dialog */ .login-dialog { - background-color: $_gdm_bg; } // buttons