Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update circuit breaker naming convention #841

Open
bishnuag opened this issue Oct 28, 2022 · 0 comments
Open

Update circuit breaker naming convention #841

bishnuag opened this issue Oct 28, 2022 · 0 comments

Comments

@bishnuag
Copy link
Contributor

  • Current circuit breaker naming convention is {clientName}-{serviceProcedureName}
  • The QPS level is captured per serviceProcedureName level
  • However, the above approach fails when a client has multiple services and each service has the same procedure. QPS level information is kept in a map (procedureName to qps level) and keeps the last value for multiple keys having same value
  • To correct this we should update the circuit breaker name as {clientName}-{serviceName}-{serviceProcedureName}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant