-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify JMH Benchmark Workflow For Shellcheck #813
Conversation
Co-authored-by: Manu Sridharan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Mostly looks great, but I have a couple comments
@@ -1,9 +1,9 @@ | |||
#!/bin/bash | |||
|
|||
cd $BRANCH_NAME/ | |||
cd "$BRANCH_NAME/" || exit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all these cases of || exit
I'm concerned that if the command ever fails (which I don't expect) it will be very difficult to diagnose. Does shellcheck still complain about the missing || exit
if you do #!/bin/bash -eux
at the beginning of the scripts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using -eux is probably a better way to do it for our case. Updated accordingly
BTW, a general tip with git is to make changes in your fork on a branch other than |
Co-authored-by: Manu Sridharan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Fixed Shellcheck errors for JMH workflow files.