New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an InvokeOption for executing an Invoke at the root-module level. #943

Open

sywhang opened this issue Sep 24, 2022 · 1 comment

Assignees

Labels

Contributor

sywhang commented Sep 24, 2022

When writing fx.Modules, it may be desirable sometimes to be able to run the Invoke at the root-module level.

We can do this by exposing an InvokeOption that can be passed to fx.Invoke.

Internal Ref: GO-1676

sywhang self-assigned this

sywhang added the enhancement label

Contributor

jkanywhere commented Jan 14, 2023

What is the expected difference in behavior between Invoke in an fx.Module vs Invoke at the root level?

Also, the internal ticket GO-1676 is closed Won't Do. Perhaps this issue should be closed as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment