From 8e7495831dbfb0c920091175779e259a5b373e54 Mon Sep 17 00:00:00 2001 From: Adam Martin Date: Mon, 19 Aug 2019 16:49:46 +1000 Subject: [PATCH] MSOffice 16 User Agent #405 Should resolve to Outlook 2016 - modified regex and added a test --- regexes.yaml | 2 +- tests/test_ua.yaml | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/regexes.yaml b/regexes.yaml index 2c56b315..19ad1344 100644 --- a/regexes.yaml +++ b/regexes.yaml @@ -454,7 +454,7 @@ user_agent_parsers: v1_replacement: '2013' # Outlook 2016 - - regex: 'Microsoft Outlook (?:Mail )?16\.\d+\.\d+' + - regex: 'Microsoft Outlook (?:Mail )?16\.\d+\.\d+|MSOffice 16' family_replacement: 'Outlook' v1_replacement: '2016' diff --git a/tests/test_ua.yaml b/tests/test_ua.yaml index 2cacbcaa..65ce5f20 100644 --- a/tests/test_ua.yaml +++ b/tests/test_ua.yaml @@ -6903,6 +6903,12 @@ test_cases: minor: patch: + - user_agent_string: 'Mozilla/4.0 (compatible; ms-office; MSOffice 16)' + family: 'Outlook' + major: '2016' + minor: + patch: + - user_agent_string: 'Outlook-Express/7.0 (MSIE 7.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; TmstmpExt)' family: 'Windows Live Mail' major: