Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a scope selector in the extension popup with dynamic filtering #1563

Closed
7 tasks done
omentic opened this issue Apr 24, 2021 · 7 comments
Closed
7 tasks done

Add a scope selector in the extension popup with dynamic filtering #1563

omentic opened this issue Apr 24, 2021 · 7 comments
Labels
duplicate This issue or pull request already exists

Comments

@omentic
Copy link

omentic commented Apr 24, 2021

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • [~] I checked the documentation to understand that the issue I report is not a normal behavior
    • It is, this is a feature request

Description

Currently, when on a URL that has subdomains (as an example, Old Reddit), it is impossible to define Dynamic Filters for that subdomain. This of course can be worked around by manually writing rules, but it would be much appreciated if it could be done in the interface as well.

A specific URL where the issue occurs

https://old.reddit.com

Steps to Reproduce

  1. Enable Advanced Mode for Dynamic Filtering
  2. [Second Step]
  3. [and so on...]

Expected behavior:

Screenshot from 2021-04-23 22-32-52

My suggestion would be for different parts of the URL under the power button to be clickable to change the scope. The scope in question would be bold.

For example, the default scope is old.reddit.com (even though only old.reddit.com is bolded in the above screenshot - I hope that doesn't serve another purpose). To change the scope to all of old.reddit.com, I would click the reddit part of the url. For all .com domains, old.reddit.com would be clickable.

This would act similar to the scope selector in uMatrix.

Actual behavior:

There is no way that I know of to apply Dynamic Filtering to a subdomain from the UI.

Your environment

  • uBlock Origin version: 1.34.0
  • Browser Name and version: Ungoogled Chromium 88.0
  • Operating System and version: Linux 5.11
@uBlock-user uBlock-user added the enhancement New feature or request label Apr 24, 2021
@uBlock-user uBlock-user changed the title Addressing subdomains in the extension popup with dynamic filtering Add a scope selector in the extension popup with dynamic filtering Apr 24, 2021
@uBlock-user
Copy link
Contributor

Sounds like gorhill/uBlock#3297 ?

@omentic
Copy link
Author

omentic commented Apr 24, 2021

Kind of, that seems more about the default setting rather than implementing an actual scope selector. This issue probably supersedes it.

Out of curiosity, are the open issues on the old uBlock tracker still considered active?

@uBlock-user
Copy link
Contributor

Out of curiosity, are the open issues on the old uBlock tracker still considered active?

Yes.

@gorhill
Copy link
Member

gorhill commented Apr 24, 2021

Duplicate of #730, which has been set as duplicate of gorhill/uBlock#3297.

@gorhill gorhill closed this as completed Apr 24, 2021
@gorhill gorhill added the duplicate This issue or pull request already exists label Apr 24, 2021
@uBlock-user uBlock-user removed the enhancement New feature or request label Apr 24, 2021
@omentic
Copy link
Author

omentic commented Apr 24, 2021

@gorhill Would you mind leaving this issue open instead, since it's on the new tracker and non-contributors can participate?

@gorhill
Copy link
Member

gorhill commented Apr 24, 2021

People can freely comment here.

@ccoager
Copy link

ccoager commented Aug 10, 2023

I can't comment on the old ticket tracker so I'll add my feedback here. I think a feature like this would be very desirable to those that use medium/hard mode and have to modify rules often.

A few more ideas to implement in the UI:

  • Use an expanded field on the source domain like the UI is already doing for destination domains. Clicking on the "..." would expand/shrink the list of domains. If you have advanced user enabled, the panel would auto-expand already like it does for destination domains. Then click and highlight the source domain to interact with when adding rules. If you don't highlight a domain, it would default to the domain in the URL.
  • Make the source domain a drop-down menu to select which to interact with. Default to the domain in the URL.

Another idea could be to add an advanced setting boolean for source domains to add rules on the root level domain or not. This could also work in conjunction with the default source domain selected for the UI implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants