Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skyscanner.com: ads #26590

Closed
10 of 11 tasks
hir0xygen opened this issue Dec 22, 2024 · 1 comment
Closed
10 of 11 tasks

skyscanner.com: ads #26590

hir0xygen opened this issue Dec 22, 2024 · 1 comment

Comments

@hir0xygen
Copy link

Prerequisites

  • This is NOT a YouTube, Facebook, Twitch or a shortener/hosting site report. These sites MUST be reported by clicking their respective links.
  • I read and understand the policy about what is a valid filter issue.
  • I verified that this issue is not a duplicate. (Search here to find out.) Comment in the old issue threads even when they are closed.
  • I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
  • I did not enable additional filter lists, or I have verified that the issue still occurs without enabling additional filter lists.
  • I do not have custom filters/rules, or I have verified that the issue still occurs without custom filters/rules.
  • I am not using uBlock Origin along with other content blockers.
  • I have verified that the web browser's built-in content blocker/tracking protection, network wide/DNS blocking, or my VPN is not causing the issue.
  • I have verified that other extensions are not causing the issue.
  • If this is about a breakage or detection, I have verified that it is caused by uBlock Origin and isn't a site issue.
  • I did not answer truthfully to ALL the above checkboxes.

URL(s) where the issue occurs.

https://skyscanner.de/
https://skyscanner.com/

Description

Skyscanner inserts sponsored flight recommendations into the list of results when searching for flights.
Recommendation:
skyscanner.de,skyscanner.com#?#div:has(> .FlightsInline_link__MTBkM)

Other extensions used

none

Screenshot(s)

Screenshot(s)

image

Configuration

Details
uBlock Origin: 1.61.2
Firefox: 133
filterset (summary):
 network: 271353
 cosmetic: 264432
 scriptlet: 55019
 html: 2512
listset (total-discarded, last-updated):
 added:
  adguard-generic: 85675-4229, now
  adguard-mobile: 10029-60, now
  adguard-spyware-url: 1850-135, now
  adguard-spyware: 116581-1573, now
  block-lan: 64-0, now
  curben-phishing: 582-2, now
  adguard-cookies: 32835-66, now
  ublock-cookies-adguard: 1986-21, 1h.15m
  fanboy-cookiemonster: 51597-4055, now
  ublock-cookies-easylist: 1986-1986, 1h.15m
  adguard-social: 23273-52, now
  fanboy-social: 16529-760, now
  [11 lists not shown]: [too many]
 default:
  user-filters: 22-2, never
  ublock-filters: 41163-134, now
  ublock-badware: 12550-1, now
  ublock-privacy: 1671-23, now
  ublock-unbreak: 2603-1, now
  ublock-quick-fixes: 172-5, now
  easylist: 78226-2440, now
  easyprivacy: 53330-29696, now
  urlhaus-1: 24645-0, now
  plowe-0: 3548-1493, now
filterset (user): [array of 21 redacted]
trustedset:
 added: [array of 5 redacted]
userSettings:
 advancedUserEnabled: true
hiddenSettings: [none]
supportStats:
 allReadyAfter: 2216 ms
 maxAssetCacheWait: 994 ms
 cacheBackend: indexedDB
popupPanel:
 blocked: 7
 network:
  skyscanner.de: 5
  newrelic.com: 2
 extended:
  ##div:has(> .FlightsInline_link__MTBkM)
@ci-r
Copy link

ci-r commented Dec 23, 2024

Target Sponsor button

skyscanner.*##div[id*="-first-result" i]:has(button[class*="SponsoredInfoButton" i]), div[class*="ItineraryInlinePlusWrapper" i]:has(button[class*="SponsoredInfoButton" i]), div[class*="InlineBrandBanner" i]:has(button[class*="SponsoredInfoButton" i])

ci-r added a commit to ci-r/easylist that referenced this issue Dec 23, 2024
- target sponsor button instead of text match.
- multilingual site, hence cannot match single text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants