-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ebay.com: ads #23491
Comments
They are using |
@stephenhawk8054 can't we use |
Every item has |
|
Oh, didn't know there's |
so is it solvable or not? |
Others may find some ways, but currently I don't know how to address it. It uses 2 |
From what I can tell, the rotation and attribute values are generated randomly, server-side on each page load (blocking all scripts, changes nothing). The attribute value is mentioned in another element though, so we'd need a procedural that can check the value of the ID in one element against the value of another attribute in listing items. |
Should be possible with XPath. |
I was wondering about that. But it's not within my skillset to attempt this.
|
Are we talking about Sponsored in the screenshot? I don't see sponsored at all, maybe geolocation. When I visit |
What exactly? |
It seems Sponsored items have longer links like FB. Or just |
I've mentioned them above. The value of id in
Oh, it is? Guess we can check that. That selector doesn't work for me though - it only finds one thing which is not part of the results? https://imgur.com/RcLh4bB.png and https://imgur.com/TAZs58j.png |
Maybe geolocation, it's working for me and I'll add to EL unless it causes FP on your side. Whoops, the rule leaves leftover. So |
@Yuki2718, this filter is not working for me, sponsored items still shown |
I know, but I first have to reproduce the ads you guys see. Which country do you access from? |
on my example page your filter is working fine (FR, US, DE, etc) |
You're right. The filter works fine when browsing by category. It just doesn't affect search results
|
@Yuki2718, Israel
@u-RraaLL, not for me. This is a screen shot from the page you linked to: |
I was replying to mapx, who was referring to his URL which is "browse by a category". I said the filter doesn't work on search results and provided an example for that. So you're just confirming what I said :) |
Test
Looks doesn't work, maybe needs |
When creating the filter, it is working, but after page refresh the sponsored items are shown again |
The rule works with AdGuard but with noticeble delay to display the page. So I suspect it's a matter of
doesn't work. Any idea? And somehow if I add |
Maybe STR
But |
Do not use wildcard, this executes xpath on every element (freezes my browser). Start with body or html. No idea why it works fine in picker, but does not from my filters. |
Should |
Maybe xpath executes too early?
This selector works only after the page finished loading. Earlier there's another element there too. It corresponds to the "dummy sponsored" and gets deleted by an inline script. |
any updates? |
Userscript which hide the ads in the search results:
|
So this can be fixed with rpnt. I still wonder why the xpath filter doesn't work with uBO. BTW |
So
to cover also regional sites like |
@JobcenterTycoon you forgot to close this issue |
I don't know why you closed this issue. Ads are still shown on eBay. |
There were no feedbacks at that time (5 months ago), so it's normal to close. If you see the ads, just continue here, no need for asking why closing the issue. |
I will ask why this issue is closed, because I can't reopen it my self. The problem never solved. No one asked for feedback. |
No one was able to reproduce the issue after the filters were added, hence it's closed. If no one continued commenting, we of course couldn't know the issue's state. Anyways, if any volunteers are able to reproduce, they will re-open. |
Though I can reproduce on |
I keep this opened since it might be worth @gorhill 's investigation why |
No one said he is unable to reproduce, because no one asked to try it. I can't even find this filter in my uBO. |
Yes, that filter is too CPU expensive to enforce: Execution time well over a second per DOM mutation processing cycle, so uBO disables it. When I use this filter in AdGuard MV3, it does work, but page load takes very long, and profiler shows that over 20 seconds was spend in AdGuard's content script's code at page load time, and more specifically the browser's own |
There were 2 comments for 2 filters above. Anyone who wants to test can read the above: We are not customer service to ask each person for testing, everyone can read the comments. Btw, this one looks working for me, but I'm not too sure: ebay.com##+js(rpnt, script, (function(scope){, '(()=>{document.querySelectorAll("li.s-item").forEach((item=>{const divItem=item.querySelector("span[data-w] > div");const styles=window.getComputedStyle(divItem);let sums=0;for(const style of["padding-top","transform","margin-top"]){if(style==="transform"){const matrix=new WebKitCSSMatrix(styles.webkitTransform);sums+=matrix.m42}else{sums+=window.parseInt(styles[style].split("px")[0])}}if(sums===0){item.style.display="none"}}))})();(function(scope){') I haven't tested with other TLDs ( |
It works on my end, feel free to add. The thing is just that nobody seems to be willing to keep the cat-and-mouse game with them. |
Prerequisites
URL address of the web page
https://www.ebay.com/sch/i.html
Category
ads
Description
Some sponsored listings are appears in search results in eBay
Other extensions used
CanvasBlocker
Screenshot(s)
Screenshot(s)
Configuration
The text was updated successfully, but these errors were encountered: