Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search.brave.com: ads #17949

Closed
8 of 9 tasks
craciu25yt opened this issue May 5, 2023 · 13 comments
Closed
8 of 9 tasks

search.brave.com: ads #17949

craciu25yt opened this issue May 5, 2023 · 13 comments
Labels
fixable by EasyList EasyList list

Comments

@craciu25yt
Copy link

craciu25yt commented May 5, 2023

Prerequisites

  • I read and understand the policy about what is a valid filter issue.
  • I verified that this issue is not a duplicate. (Use this button to find out.)
  • I forced an update of my filter lists. (Click the "Purge all caches" button while holding the 'Shift' key, then click the "Update now" button.)
  • I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
  • I did not enable external filter lists, or I have verified that the issue still occurs without enabling external filter lists.
  • I do not have custom filters/rules, or I have verified that the issue still occurs without custom filters/rules.
  • I am not using uBlock Origin (uBO) along with other content blocker extensions.
  • I have verified that the web browser's built-in blocker or DNS blocking (standalone or through a VPN) is not causing the issue.
  • I did not answer truthfully to ALL the above checkpoints.

URL address of the web page

https://search.brave.com/search?spellcheck=0&q=js+change+element+colors

Category

ads

Description

it shows the premium subscription ad to remove ads.
Fix:

! 2023-05-05 https://search.brave.com
search.brave.com###premium-promo-wrapper

Screenshot(s)

Screenshot(s)

image

Configuration

Settings
uBlock Origin: 1.49.2
Chromium: 113
filterset (summary): 
 network: 224737
 cosmetic: 228815
 scriptlet: 39519
 html: 0
listset (total-discarded, last-updated): 
 added: 
  adguard-annoyance: 67838-92, 2d.2h.43m
  adguard-generic: 70506-512, 2d.2h.41m
  adguard-mobile: 8713-46, 2d.2h.46m
  adguard-social: 20396-860, 2d.2h.42m
  adguard-spyware-url: 1004-3, 2d.2h.44m
  block-lan: 47-0, 5d.23h.2m
  curben-phishing: 86729-2, 28m
  curben-pup: 190-0, 29m
  dpollock-0: 11357-82, 1d.3h.46m
  fanboy-annoyance: 90375-21141, 7d.3h.9m
  fanboy-cookiemonster: 61256-61256, 7d.3h.8m
  fanboy-social: 17210-17186, 2d.2h.45m
  fanboy-thirdparty_social: 68-18, 7d.3h.10m
  ublock-annoyances: 4971-259, 6d.4h.4m
 default: 
  user-filters: 2-0, never
  easylist: 66561-1175, 2d.2h.40m
  easyprivacy: 32233-338, 2d.2h.39m
  plowe-0: 3746-1383, 8d.5h.29m
  spa-0: 3624-37, 30m
  spa-1: 5195-214, 2d.2h.47m
  ublock-abuse: 70-0, 8d.5h.28m
  ublock-badware: 7094-375, 1d.3h.45m
  ublock-filters: 33357-4129, 1d.3h.45m
  ublock-privacy: 323-7, 8d.5h.27m
  ublock-quick-fixes: 228-26, 6h.11m
  ublock-unbreak: 2007-97, 1d.3h.45m
  urlhaus-1: 7542-5, 27m
filterset (user): [array of 2 redacted]
trustedset: 
 added: [array of 3 redacted]
modifiedUserSettings: [none]
modifiedHiddenSettings: [none]
supportStats: 
 allReadyAfter: 973 ms (selfie)
 maxAssetCacheWait: 714 ms
popupPanel: 
 blocked: 5
 network: 
  brave.com: 5
 cosmetic: 
  ##div[data-advertiser-id]
  ##[data-type=\"ad\"]
  ###usage-metrics
@krystian3w
Copy link
Contributor

Compatible with EasyList, and what was done on sending report, so that broke harmony in sections under "Fix:" (...?).

@peace2000 peace2000 added the fixable by EasyList EasyList list label May 5, 2023
@peace2000
Copy link
Member

Hi, as this is fixable by Easylist, please file your report here: https://github.com/easylist/easylist/issues/

(Just copy your message there).

@iam-py-test
Copy link
Contributor

it shows the premium subscription ad to remove ads.

Isn't that self-promo, which is out of scope of EasyList and uAssets? Or am I an idiot and misread this?

@krystian3w
Copy link
Contributor

krystian3w commented May 5, 2023

Can be addresed in EasyList Annoyances or legacy "Fanboy Annoyances".

For the time being, I do not track whether gorhill has activated the merging of the cookie list and social media in its mirror (So that people would not change old habits).


Theoretically, it minimally resembles a widget on Reddit, which is only suitable for addressing as an annoyance (aside from the fact that an interface based on something similar to react has no readable class/id).

@peace2000
Copy link
Member

it shows the premium subscription ad to remove ads.

Isn't that self-promo, which is out of scope of EasyList and uAssets? Or am I an idiot and misread this?

Outlook "ads" or "self-promo" is also handled in uAssets. Personally I think that if self-promo is annoying, it should be handled.

@krystian3w
Copy link
Contributor

So made PR.

@luftra
Copy link

luftra commented Dec 22, 2024

Brave Sponsored Ads aren't getting blocked, even with EasyList Annoyances.

Screenshot 2024-12-21 205328

@uBlock-user
Copy link
Contributor

@ryanbr

@luftra
Copy link

luftra commented Dec 26, 2024

Any ETA, if I may ask?

@stephenhawk8054
Copy link
Member

Which browser are you using?

@ryanbr
Copy link
Contributor

ryanbr commented Dec 26, 2024

I can't repo, but if you want to block Brave search ads with Brave shields, use Aggresive mode in shields on search.brave.com

@uBlock-user
Copy link
Contributor

@luftra can't repro on Firefox or Brave

@luftra
Copy link

luftra commented Dec 27, 2024

I can't repo, but if you want to block Brave search ads with Brave shields, use Aggresive mode in shields on search.brave.com

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixable by EasyList EasyList list
Projects
None yet
Development

No branches or pull requests

8 participants