Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another CFG construction crash when both cases of a ConditionalExpression are the null literal #6785

Closed
msridhar opened this issue Sep 4, 2024 · 1 comment · Fixed by #6786

Comments

@msridhar
Copy link
Contributor

msridhar commented Sep 4, 2024

Following up to #6743 I am still seeing a crash during CFG construction but with a slightly different test input:

public class Crash {
  String foo2(String x) { return x.isEmpty() ? null : null; }
}

Sorry I should have tested out the previous fix earlier; I just got to testing it with the 3.47.0 release. An input like the above still crashes NullAway.

@msridhar
Copy link
Contributor Author

msridhar commented Sep 5, 2024

Thanks for the fix! I confirmed the NullAway crash no longer appears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant