Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicating transaction generation #444

Open
mmontin opened this issue Jul 31, 2024 · 0 comments
Open

Deduplicating transaction generation #444

mmontin opened this issue Jul 31, 2024 · 0 comments

Comments

@mmontin
Copy link
Collaborator

mmontin commented Jul 31, 2024

At the moment we generate the transaction twice:

  • during balancing
  • afterwards, in validateTxSkel

We could imagine that that the balancing could return the generated transaction so that the second generation is no longer needed. However, due to balancing option there are cases when this generation does not happen during balancing. In those cases, we could imagine two possibilities:

  • generating a transaction during balancing regardless of the given options
  • having balancing return a Maybe Tx and possibly generate the transaction in the validation process when equal to Nothing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant