Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New $grid-breakpoint-max-offset Sass variable #41195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

julien-deramond
Copy link
Member

Description

This PR addresses the use case mentioned in #41192 by defining the .02 value as a Sass variable, making it customizable externally.

I don’t believe this change necessarily needs to be documented as it's rather an edge case of customization.

The corresponding issue is for now linked to the v5.4.0 project as it's kind of a new feature, but could be merged in a v5.3.x as non-breaking.

Motivation & Context

Allow users to customize this value.

Type of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (N/A) My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

N/A

Related issues

Closes #41192

@mdo
Copy link
Member

mdo commented Jan 31, 2025

Let's hold on this until we figure out media queries for next versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable for subtract .02px
2 participants