Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"useChryslerMAPCorrection" Is Broken #28

Open
FlashStopFall opened this issue Aug 2, 2024 · 0 comments
Open

"useChryslerMAPCorrection" Is Broken #28

FlashStopFall opened this issue Aug 2, 2024 · 0 comments

Comments

@FlashStopFall
Copy link

FlashStopFall commented Aug 2, 2024

useChryslerMAPCorrection has been broken since commit 419973f, with the last working version being commit a50af8e. (Arduino nano 328p, legacy board, legacy LCD, legacy buttons, but it doesn't compile for any board).

Commit 419973f (above) gives a different error (Compilation error: 'prgmCalculateMAPpressure') was not declared in this scope than the current main/develop build (Compilation error: 'tPressureChannel' was not declared in this scope). The earliest commit I happened to track this to was e6930e7.

It appears some code was moved out of trip_measurement.h and functions.h into trip_measurement.ino, and that broke things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant