Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration flag to allow fixuping commits authored not by me #140

Closed
TheNeikos opened this issue Jan 29, 2025 · 5 comments · Fixed by #143
Closed

Configuration flag to allow fixuping commits authored not by me #140

TheNeikos opened this issue Jan 29, 2025 · 5 comments · Fixed by #143

Comments

@TheNeikos
Copy link

Thanks for the tool!

Its a huge help, but I often find myself in a pair-program situation where a colleague and I exchange a branch until its done. In those situations we do create fixups for eachother's commits.

Currently the tool does not allow this per-default, and I find that --force seems a bit... scary. I don't know exactly which safety aspects it disables.

My question thus is: Could there be a config flag that allows also fixuping other authors' commits?

@blairconrad
Copy link
Contributor

blairconrad commented Jan 29, 2025

@TheNeikos, this sounds great. There's even a note in the README to do this, "add smaller force flags to disable individual safety checks" (of course, there's also "implement force flag").

Scraping the code, it looks like force

@tummychow aside from interfering with any response that you were going to make, I'm also here to advocate for whatever specific flag might come from this to have a corresponding configuration option, as I would be pretty likely to always specify --not-just-my-commits (or whatever).

I have never rusted before, but if you're into the feature and don't have time to implement, I'd take a stab at implementing...

@matthiasbeyer
Copy link

I'd like to add that this should also be configurable (via the normal git mechanisms, so git config ...), so a user is able to configure this per repository and does not have to think about passing the right flags 😉

@blairconrad
Copy link
Contributor

I thought that's what I said, @matthiasbeyer. 😉

@matthiasbeyer
Copy link

Meh, my brain scanned too fast over your response. Sorry about that.

@tummychow
Copy link
Owner

yes, i would accept a pr for a new flag (eg --force-author) that specifically only does this. --force should maintain the existing behavior. git config option for forcing author would also be accepted as part of that pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants