Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling with emscripten fails #161

Open
Maddimax opened this issue Jan 30, 2025 · 1 comment
Open

Compiling with emscripten fails #161

Maddimax opened this issue Jan 30, 2025 · 1 comment

Comments

@Maddimax
Copy link

Compiling with emscripten fails with:

369.4 signals.c:146:4: error: call to undeclared function 'mythread_sigmask'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
369.4   146 |                         mythread_sigmask(SIG_BLOCK, &hooked_signals, NULL);
369.4       |                         ^
369.4 signals.c:146:4: note: did you mean 'pthread_sigmask'?
369.4 /emsdk/upstream/emscripten/cache/sysroot/include/signal.h:230:5: note: 'pthread_sigmask' declared here
369.4   230 | int pthread_sigmask(int, const sigset_t *__restrict, sigset_t *__restrict);
369.4       |     ^
369.4 signals.c:163:4: error: call to undeclared function 'mythread_sigmask'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
369.4   163 |                         mythread_sigmask(SIG_UNBLOCK, &hooked_signals, NULL);

mythread_sigmask was disabled here: 81db3b8

Should the calling code get #if-defed out as well for WASM?

Larhzu added a commit that referenced this issue Jan 30, 2025
mythread.h omits mythread_sigmask on WASM.

Fixes: #161
See: 81db3b8
@Larhzu
Copy link
Member

Larhzu commented Jan 30, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants