Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE7 boxsizing.htc being included in IE8 also #4

Open
LeighBicknell opened this issue Jan 17, 2013 · 1 comment
Open

IE7 boxsizing.htc being included in IE8 also #4

LeighBicknell opened this issue Jan 17, 2013 · 1 comment

Comments

@LeighBicknell
Copy link

Currently in _system.scss (around line 89) the IE7 box-sizing support 'behavior' attribute is also being applied to IE8 and breaking it's layout. Adding a * before 'behavior:' will cause IE8 to ignore this, solving the problem.

I've compiled mine using phpsass and it compiles fine this way, I'm not sure if Compass will compile it properly with the * in there though, so it may be worth checking this first.

@tsi
Copy link
Owner

tsi commented Jan 17, 2013

The star hack won't be a problem with compass since compass uses that too.
But since IE8 supports box-sizing, the fact that the polyfill breaks the layout sounds to me like a bug in the polyfill. the project page on github clearly says:

I also added feature-detection for box-sizing, to do nothing when detected positive.

It also recommends using the star hack for better performance. and compass does that, so I guess we should too. I just hate shipping IE hacks out-of-the-box. even though they'll be printed only if $ie7-support: true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants