Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY up the query code #168

Closed
jcrossley3 opened this issue Apr 16, 2024 · 0 comments · Fixed by #181
Closed

DRY up the query code #168

jcrossley3 opened this issue Apr 16, 2024 · 0 comments · Fixed by #181
Assignees
@jcrossley3

Comments

@jcrossley3
Copy link
Contributor 

          I've also used this pattern, and while not on your shoulders, I feel like we are repeating ourselves a lot, and perhaps @jcrossley3 could get us some more ergonomics around using search/sort.

Originally posted by @bobmcwhirter in #167 (comment)
@jcrossley3 jcrossley3 self-assigned this Apr 16, 2024
@jcrossley3 jcrossley3 mentioned this issue Apr 17, 2024
Merged
jcrossley3 added a commit to jcrossley3/trustify that referenced this issue Apr 17, 2024
@jcrossley3
refactor the filtering logic into a single filtering fn
6ffa59c 
Fixes trustification#168

Signed-off-by: Jim Crossley <[email protected]>
@jcrossley3 jcrossley3 mentioned this issue Apr 17, 2024
Merged
jcrossley3 added a commit to jcrossley3/trustify that referenced this issue Apr 17, 2024
@jcrossley3
refactor the filtering logic into a single filtering fn
c3e8eaa 
Fixes trustification#168

Signed-off-by: Jim Crossley <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Apr 18, 2024
@jcrossley3
refactor the filtering logic into a single filtering fn
f261605 
Fixes #168

Signed-off-by: Jim Crossley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcrossley3 jcrossley3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor the filtering logic into a single filtering fn jcrossley3/trustify
1 participant
@jcrossley3