Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add callee ip in RpcContext #65

Merged

Conversation

nicklaus-dev
Copy link
Contributor

see #64

Copy link

github-actions bot commented Sep 20, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.06523%. Comparing base (acdbb07) to head (779c0c1).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##                master         #65         +/-   ##
=====================================================
- Coverage     70.13407%   70.06523%   -0.06884%     
+ Complexity        4204        4199          -5     
=====================================================
  Files              434         434                 
  Lines            17006       17017         +11     
  Branches          1726        1726                 
=====================================================
- Hits             11927       11923          -4     
- Misses            3964        3971          +7     
- Partials          1115        1123          +8     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nt/trpc/core/filter/ConsumerInvokerHeadFilter.java 84.84848% <100.00000%> (+4.84847%) ⬆️
...nt/trpc/core/filter/ProviderInvokerHeadFilter.java 83.33333% <100.00000%> (+0.98038%) ⬆️
...com/tencent/trpc/core/rpc/RpcContextValueKeys.java 0.00000% <ø> (ø)

... and 8 files with indirect coverage changes

@nicklaus-dev
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

liuzengh added a commit to trpc-group/cla-database that referenced this pull request Sep 20, 2024
@nicklaus-dev nicklaus-dev reopened this Sep 20, 2024
import com.tencent.trpc.core.rpc.RpcClientContext;
import com.tencent.trpc.core.rpc.RpcServer;
import com.tencent.trpc.core.rpc.RpcServerManager;
import com.tencent.trpc.core.rpc.*;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不能import*,import具体的类

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已处理

import com.tencent.trpc.core.rpc.RequestMeta;
import com.tencent.trpc.core.rpc.Response;
import com.tencent.trpc.core.rpc.RpcContext;
import com.tencent.trpc.core.rpc.*;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不能import *

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已处理

@wardseptember wardseptember merged commit 9018c10 into trpc-group:master Sep 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants