-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add callee ip in RpcContext #65
add callee ip in RpcContext #65
Conversation
All contributors have signed the CLA ✍️ ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
=====================================================
- Coverage 70.13407% 70.06523% -0.06884%
+ Complexity 4204 4199 -5
=====================================================
Files 434 434
Lines 17006 17017 +11
Branches 1726 1726
=====================================================
- Hits 11927 11923 -4
- Misses 3964 3971 +7
- Partials 1115 1123 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I have read the CLA Document and I hereby sign the CLA |
import com.tencent.trpc.core.rpc.RpcClientContext; | ||
import com.tencent.trpc.core.rpc.RpcServer; | ||
import com.tencent.trpc.core.rpc.RpcServerManager; | ||
import com.tencent.trpc.core.rpc.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不能import*,import具体的类
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已处理
import com.tencent.trpc.core.rpc.RequestMeta; | ||
import com.tencent.trpc.core.rpc.Response; | ||
import com.tencent.trpc.core.rpc.RpcContext; | ||
import com.tencent.trpc.core.rpc.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不能import *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已处理
see #64