Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix literal rhythm application #31

Open
trevorbaca opened this issue Dec 17, 2018 · 0 comments
Open

Fix literal rhythm application #31

trevorbaca opened this issue Dec 17, 2018 · 0 comments
Assignees
Labels

Comments

@trevorbaca
Copy link
Owner

trevorbaca commented Dec 17, 2018

This works as expected:

maker(
    (['vn', 'va'], 1),
    baca.make_notes(),
    )

This mangles score output:

maker(
    (['vn', 'va'], 1),
    baca.rhythm("{ c'1 }"),
    )

Problem probably arises because rhythm is initialized only once; this will generate a reference problem causing violin and viola to point to same components. Change command to store input string and then evaluate input string once per score insertion.

@trevorbaca trevorbaca added the bug label Dec 17, 2018
@trevorbaca trevorbaca self-assigned this Dec 17, 2018
@trevorbaca trevorbaca changed the title Fix literal rhythms Fix literal rhythm application Dec 17, 2018
@trevorbaca trevorbaca changed the title Fix literal rhythm application Make rhythm enhancements Jul 5, 2019
@trevorbaca trevorbaca changed the title Make rhythm enhancements Fix literal rhythm application Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant