Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x doesn't select latest 1 major series version #149

Open
myitcv opened this issue Jun 4, 2018 · 3 comments
Open

1.x doesn't select latest 1 major series version #149

myitcv opened this issue Jun 4, 2018 · 3 comments

Comments

@myitcv
Copy link

myitcv commented Jun 4, 2018

Build https://travis-ci.org/myitcv/vgoimporter/builds/387659191 uses the 1.x selector for a Go version:

myitcv/vgoimporter@26615dd#diff-354f30a63fb0907d4ad57269548329e3R11

But this ends up resolving to 1.10.1, despite 1.10.2 currently being the latest version.

@philpennock
Copy link
Contributor

That 1.x resolution is happening inside Travis's config handling system, before gimme is involved.

With current master HEAD gimme, we see:

% gimme -r 1.x
1.10.2

I don't recall where this belongs in Travis's repos, but not here, and if they used gimme to resolve, then this wouldn't happen.

@myitcv
Copy link
Author

myitcv commented Jun 5, 2018

Thanks @philpennock

That 1.x resolution is happening inside Travis's config handling system, before gimme is involved.

Does this correspond with travis-ci/travis-build#1388?

/cc @BanzaiMan

@philpennock
Copy link
Contributor

Looks like it, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants