Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make generating nl_descriptions more dynamic #19

Open
RogerTangos opened this issue Jul 17, 2018 · 1 comment
Open

Make generating nl_descriptions more dynamic #19

RogerTangos opened this issue Jul 17, 2018 · 1 comment
Labels
enhancement

Comments

@RogerTangos
Copy link
Contributor

trane.utils.generate_nl_description currently assumes exactly 4 operations in the order filter -> row -> transformation -> aggregation. It should be able to handle multiple or no operations in any category.

Including some sort of describe method in the op classes may help.
@RogerTangos
Copy link
Contributor Author

Resolved in f69ac3e.

Problems are now described using the str method, and operations can be in any any logically consistent sequence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RogerTangos