🚀 Feature: Add instruments support for httpx

[damianoneill]

Which component is this feature for?

All Packages

🔖 Feature description

Today the solution currently supports Instruments.REQUESTS and Instruments.URLLIB3. Is there any plans to extend the instruments to support HTTPX?

🎤 Why is this feature needed ?

Many libraries that require async support have migrated from requests to httpx. Providing httpx support natively would extend the use of this library to a larger user base.

✌️ How do you aim to achieve this?

Ideally, this feature would provide similar ease of configuration as is currently available for Requests.

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

• I checked and didn't find similar issue

Are you willing to submit PR?

None

[nirga]

Definitely @damianoneill! Do you think we should add it always by default?

[damianoneill]

@nirga I think the best approach is to behave like REQUESTS since the userbase will likely use them similarly.

[ghost]

Hi @nirga,
I'm new to open-source and would love to take this up.

[nirga]

Sounds good @whoiskrtk2! Let me know if you have any questions. Should be fairly straightforward

[ghost]

I plan to look into the instrumentation for requests and urllib and try to port that for httpx. It may need some work given that httpx supports asyncio and HTTP 2, but should be a good experience. I'll reach out if I get stuck anywhere. Thanks!

[haf]

Quick question: isn't it a bit bloated of your package to depend on every package under the sun?

[nirga]

@haf wdym by "every package under the sun"? These are small-footprint packages. Even if we depended on all instrumentations (which we don't) it would have been still a much smaller footprint than a single numpy dependency.
It's similar to the otel auto-instrumentation package (which also depends on all instrumentations).

Do you experience any issues with that?

[haf]

It's not about the LoC you depend on, it's the fact that your package has all these other dependencies which brings the headache. Isn't what you're doing here something for extras? https://stackoverflow.com/questions/52474931/what-is-extra-in-pypi-dependency

Edit: to answer your question. I haven't explicitly experienced any dependency conflict issues with your package no because we only depend on openai and anthropic right now, but you did break our tracing when we installed you, and the API of your package isn't fully composable (it doesn't separate side effecting calls from pure functions)

Edit 2: I would never in my life install an auto-instrumentation package from OT — the moment anything isn't working you're ****ed and have no idea where and what to investigate.