Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky] In Tournament mode, data.tourney.manager.chat value alternating between empty list and actual chats #239

Closed
VictimCrasher opened this issue Nov 16, 2024 · 2 comments · Fixed by #243
Closed

[Flaky] In Tournament mode, data.tourney.manager.chat value alternating between empty list and actual chats #239

VictimCrasher opened this issue Nov 16, 2024 · 2 comments · Fixed by #243
Labels
stable tourney All containing osu!tourney

Comments

@VictimCrasher
Copy link

Issue description

Seems to be happening in the newest update, the data.tourney.manager.chat value keeps alternating between [] and the real value on every socket update

Causing flickering on chats:

2024-11-16-Chat1.mp4

This is what it looks like when doing console.log of the value:

2024-11-16-Chat2.mp4

tosu location

D:\Documents\OsuPlugins\gosumemory
Yea I shared it with gosu, seems to work fine
But putting the file on the separate directory also does the same behavior

OS

Windows 10 Pro 22H2

Note

Tbf this can be fixed in FE but I think it'd be best to handle it from the tosu side
@VictimCrasher VictimCrasher added the question Further information is requested label Nov 16, 2024
@VictimCrasher VictimCrasher changed the title In Tournament mode, data.tourney.manager.chat value alternating between empty list and actual chats [Flaky] In Tournament mode, data.tourney.manager.chat value alternating between empty list and actual chats Nov 16, 2024
@cyperdark cyperdark added tourney All containing osu!tourney memory labels Nov 16, 2024
@cyperdark cyperdark linked a pull request Nov 17, 2024 that will close this issue
fix: fix unnecessary tournament chat reset #243
Merged
@cyperdark
Copy link
Collaborator

@VictimCrasher try this build: https://github.com/tosuapp/tosu/actions/runs/11880753880?pr=243

@cyperdark cyperdark added stable and removed memory question Further information is requested labels Nov 17, 2024
@VictimCrasher
Copy link
Author

Hello @cyperdark thanks for addressing the issue quickly 🙏

image

But using the latest build I got this error and automatically the tosu closed 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stable tourney All containing osu!tourney
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix unnecessary tournament chat reset tosuapp/tosu
3 participants
@cyperdark @KotRikD @VictimCrasher