Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image URLs aren't built with relative links #3

Open
benjamincharity opened this issue Sep 14, 2017 · 0 comments
Open

Image URLs aren't built with relative links #3

benjamincharity opened this issue Sep 14, 2017 · 0 comments

Comments

@benjamincharity
Copy link

When a user downloads the zip file to try this out, the image links are all broken as they seem to point to the path of whoever actually ran the build script. So rather than pointing to the project directory, it is using a path starting back at the user directory (which in the pre-built version points to a user directory that doesn't exist on my machine).

https://github.com/tonyganch/marked-emojis/blob/master/scripts-maker.js#L34

If I build it on my own machine, the links are correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant