Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Away streams only #32

Open
eithrial opened this issue Jun 19, 2019 · 8 comments
Open

Away streams only #32

eithrial opened this issue Jun 19, 2019 · 8 comments
Labels
enhancement New feature or request

Comments

@eithrial
Copy link

For example streamglob download://mlb/2019-06-17.tor pick away stream instead of the home one.

@tonywagner
Copy link

You might want to check out mlbv, it has this feature and was recently updated for 2019 compatibility. See the readme, section 5:

https://github.com/VirtualParticle/mlbv

mlbv --team tor --feed away # choose the away feed (assuming Toronto is the home team, you will get the opposing team's feed)

@tonycpsu
Copy link
Owner

For example streamglob download://mlb/2019-06-17.tor pick away stream instead of the home one.

I can't reproduce this. Are you using the latest git master?

@tonywagner
Copy link

I can't reproduce this. Are you using the latest git master?

I think this is a feature request. As in, they want the ability to select their favorite team's game, but get the opponent's broadcast, even if they don't know who the opponent is.

@tonycpsu tonycpsu added the enhancement New feature or request label Jun 24, 2019
@tonycpsu
Copy link
Owner

Ah! In that case, this should already be supported by updating config.yaml with the following settings:

profiles:
    default:
        providers:
            mlb:
                teams:
                    overrides:
                        - TOR:
                            feed_type: remote   # or "local"

There's no reliable way to do override the feed type from the command-line right now, but I'll fix that shortly.

tonycpsu added a commit that referenced this issue Jun 24, 2019
* Provider options set when the identifier is parsed were
  overriding command-line options.  This prevented things like
      streamglob play://phi:feed_type=away
  from working.
* This commit adds options from the provider only if they're not
  specified on the command-line.  This should enable command-line
  home/away stream selection without having to specify the name of the
  home/away team.
@tonycpsu
Copy link
Owner

As of @9706f5c, setting preferred stream should work either in the config file (by specifying remote/local for each team) or via the command-line (by adding feed_type:away to the command), e.g.:

streamglob download://mlb/2019-06-17.tor:feed_type=away

@eithrial
Copy link
Author

I use the latest version. Both commands:
streamglob download://mlb/2019-06-17.tor
streamglob download://mlb/2019-06-17.laa
pick the same stream (Angels' stream)

Also
streamglob download://mlb/2019-06-23.hou
streamglob download://mlb/2019-06-23.nyy
gives always Astros' stream.

Installing everything from the beginning doesn't change that behaviour.

@tonywagner
Copy link

Whoops, maybe it was a bug report. Sorry! :)

@KenJean
Copy link

KenJean commented Jul 24, 2019

Just wondering if this is being addressed. Like eithrial above, on certain games, I can only get the visiting-team's stream.

Otherwise, great work everyone !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants