Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with numpy 2 #168

Closed
jonimatix opened this issue Jul 31, 2024 · 2 comments
Closed

Compatibility with numpy 2 #168

jonimatix opened this issue Jul 31, 2024 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jonimatix
Copy link

Hi,

Can you please update the library to be compatible with numpy 2?

The below error is thrown when running:
estimator.fit(df['amount'].values).evaluate(1000)

np.asfarray was removed in the NumPy 2.0 release. Use np.asarray with a proper dtype instead.

Thanks

@tommyod
Copy link
Owner

tommyod commented Jul 31, 2024

Can you please update the library to be compatible with numpy 2?

Very open to PRs if you, or anyone else, wants to have a go at it. :)

I'll probably look into it eventually myself, but no guarantees as to when that happens.

@tommyod
Copy link
Owner

tommyod commented Oct 28, 2024

Closed by #171

@tommyod tommyod closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants