-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A button for Light and Dark mode #27
Comments
Yes I agree, need to find the right icon tho. I'll think of something |
Might I suggest using these light and dark icons from Material Design? I've used them before and they are quite nice. Just search up "brightness", and you'll find some nice ones. |
@tomfran You can check the icons on my website (https://neel04.github.io/my-website/) I've done a few changes to the colorscheme, but it'll fit right in to |
Hey, I can take this one. Only question is how should I configure the logic in the config? There's Open for better ideas, did not think deep on it. Here's a suggestion for the icons (let me know if you're looking for something much more aesthetic, this is just simple svg). |
I think ColorPallete 2 would be ok |
Hello @otaliptus and @Skrillx13, perhaps I didn't get your idea, but why are you thinking of a color palette 2? The color palette stuff is independent, having two different palettes, one for light and one for dark respectively, wasn't contemplated. About the icons, yes those are really generic ones, but I guess we can always change them in the future/add a configuration for them. |
I suppose that would work better. As for the icons, configuration could be added to allow the user to choose an icon from like an icon library. |
It would be nice to have a button that allows you to actually switch between light and dark mode.
The text was updated successfully, but these errors were encountered: