Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A button for Light and Dark mode #27

Open
Skrillx13 opened this issue Sep 22, 2024 · 7 comments
Open

A button for Light and Dark mode #27

Skrillx13 opened this issue Sep 22, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@Skrillx13
Copy link

It would be nice to have a button that allows you to actually switch between light and dark mode.

@tomfran
Copy link
Owner

tomfran commented Sep 22, 2024

Yes I agree, need to find the right icon tho. I'll think of something

@Skrillx13
Copy link
Author

Skrillx13 commented Sep 22, 2024

Yes I agree, need to find the right icon tho. I'll think of something

Might I suggest using these light and dark icons from Material Design? I've used them before and they are quite nice. Just search up "brightness", and you'll find some nice ones.

@neel04
Copy link

neel04 commented Oct 10, 2024

@tomfran You can check the icons on my website (https://neel04.github.io/my-website/) I've done a few changes to the colorscheme, but it'll fit right in to typo too I feel

@otaliptus
Copy link

otaliptus commented Oct 24, 2024

Hey, I can take this one.

Only question is how should I configure the logic in the config? There's theme and colorPalette, and my intuition would be adding a colorPalette2 to the config and showing the mode button on the top right in case two palettes are different, to not to add more fields to the toml file.

Open for better ideas, did not think deep on it.

Here's a suggestion for the icons (let me know if you're looking for something much more aesthetic, this is just simple svg).

image

@Skrillx13
Copy link
Author

Hey, I can take this one.

Only question is how should I configure the logic in the config? There's theme and colorPalette, and my intuition would be adding a colorPalette2 to the config and showing the mode button on the top right in case two palettes are different, to not to add more fields to the toml file.

Open for better ideas, did not think deep on it.

Here's a suggestion for the icons (let me know if you're looking for something much more aesthetic, this is just simple svg).

image

I think ColorPallete 2 would be ok

@tomfran
Copy link
Owner

tomfran commented Oct 27, 2024

Hey, I can take this one.

Only question is how should I configure the logic in the config? There's theme and colorPalette, and my intuition would be adding a colorPalette2 to the config and showing the mode button on the top right in case two palettes are different, to not to add more fields to the toml file.

Open for better ideas, did not think deep on it.

Hello @otaliptus and @Skrillx13, perhaps I didn't get your idea, but why are you thinking of a color palette 2?
My idea would be to introduce a new "manual" theme mode, alongside the existing auto, light and dark. Perhaps we could specify what theme to use on the first visit, either dark or light.

The color palette stuff is independent, having two different palettes, one for light and one for dark respectively, wasn't contemplated.
Also I feel this would complicate configuration, additionally, one can currently achieve this by defining a custom palette.

About the icons, yes those are really generic ones, but I guess we can always change them in the future/add a configuration for them.

@Skrillx13
Copy link
Author

Hey, I can take this one.
Only question is how should I configure the logic in the config? There's theme and colorPalette, and my intuition would be adding a colorPalette2 to the config and showing the mode button on the top right in case two palettes are different, to not to add more fields to the toml file.
Open for better ideas, did not think deep on it.

Hello @otaliptus and @Skrillx13, perhaps I didn't get your idea, but why are you thinking of a color palette 2? My idea would be to introduce a new "manual" theme mode, alongside the existing auto, light and dark. Perhaps we could specify what theme to use on the first visit, either dark or light.

The color palette stuff is independent, having two different palettes, one for light and one for dark respectively, wasn't contemplated. Also I feel this would complicate configuration, additionally, one can currently achieve this by defining a custom palette.

About the icons, yes those are really generic ones, but I guess we can always change them in the future/add a configuration for them.

I suppose that would work better. As for the icons, configuration could be added to allow the user to choose an icon from like an icon library.

@tomfran tomfran added the enhancement New feature or request label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants