Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use of parent:: #22

Open
tom-- opened this issue Feb 11, 2017 · 1 comment
Open

use of parent:: #22

tom-- opened this issue Feb 11, 2017 · 1 comment

Comments

@tom--
Copy link
Owner

tom-- commented Feb 11, 2017

Refactor DynamicActiveRecord so that methods use parent:: only to call the parent of the same method, e.g. DynamicActiveRecord::getAttribute() is allowed to call parent::getAttribute() but not parent::__get().

Does this improve maintainability

Is this feasible?

any thoughts @djagya ?

@djagya
Copy link
Collaborator

djagya commented Feb 11, 2017

@tom-- I read the whole discussion. Your proposal makes sense, yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants