Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subdivisions of Great Britain. #2

Open
mihxil opened this issue Oct 1, 2018 · 2 comments
Open

Subdivisions of Great Britain. #2

mihxil opened this issue Oct 1, 2018 · 2 comments

Comments

@mihxil
Copy link

mihxil commented Oct 1, 2018

If I understood correctly I could refer to 'england' according to ISO-3166-2 (https://en.wikipedia.org/wiki/ISO_3166-2:GB) as 'GB-ENG'.

This code (and others like that) is however missing in be.olsson.i18n.subdivision.SubdivisionGB

I'm not sure whether this is on purpose, or just a result of the way these classes are generated.

I could look into it, but perhaps it would be a good idea to talk about a desired solution beforehand?

@tobias-
Copy link
Owner

tobias- commented Oct 4, 2018

Interesting! This would be rather easy to implement and actually something we'd want to use as well instead of having the GB & England tuple we use today.

My source for the data is
http://www.unece.org/fileadmin/DAM/cefact/locode/Subdivision/gbSub.htm
and that contains that data, so it would be reasonably easy to fix.

@mihxil
Copy link
Author

mihxil commented Oct 5, 2018

Well, actually, somewhy http://www.unece.org/fileadmin/DAM/cefact/locode/Subdivision/gbSub.htm doesn't contain that specific data (as far as I can see). In contradiction to https://www.iso.org/obp/ui/#iso:code:3166:GB. It would perhaps be even better to use this last site as a source, but it seems technically harder to do, and I think they also charge for this data, so probably they won't appreciate it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants