Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baseline browser support #17

Open
tmedwards opened this issue Apr 24, 2020 · 2 comments
Open

Baseline browser support #17

tmedwards opened this issue Apr 24, 2020 · 2 comments
Assignees
@tmedwards
Labels
done Issue is resolved enhancement New feature or request

Comments

@tmedwards
Copy link
Owner

It's time to change SugarCube's baseline browser support.

Consider changing the baseline browser target to:

  1. Internet Explorer 11. For reference, v2's baseline target is IE 9.
  2. Browsers that support ES2015 (ES6). This pretty much means dropping ancient browsers altogether.
@greyelf
Copy link

greyelf commented Apr 25, 2020

How well does the Twine 2.x application's Test and Play options handle ES6 code?

@tmedwards
Copy link
Owner Author

The question is essentially moot for non-browser-shell Twine 2 releases as they all open in users' browsers, which puts the onus on the browser.

For the browser-shell releases, it depends on whether we're talking pre- or post- Twine 2 v2.3.

  • Post-v2.3 also makes the question moot, since releases now open new system-default browser windows for testing. Thus, the onus is again on the browser.
  • Pre-v2.3 releases do test within a new shell window, but AFAIK all of the shells supported ES2015—or, at least, since v2.1–2.2; I'm not worried about v2.0.

Make sense?

@tmedwards tmedwards transferred this issue from another repository Aug 2, 2020
@tmedwards tmedwards self-assigned this Aug 2, 2020
@tmedwards tmedwards added enhancement New feature or request investigate Information gathering is needed todo Make this happen labels Aug 2, 2020
tmedwards added a commit that referenced this issue Dec 1, 2020
@tmedwards
UPDATE: Update browser support targets. Resolves #17 .
91802e4 
SEE: `.browserslistrc` for details on support query.
@tmedwards tmedwards added done Issue is resolved and removed investigate Information gathering is needed todo Make this happen labels Dec 1, 2020
tmedwards added a commit that referenced this issue Dec 2, 2020
@tmedwards
UPDATE: Update browser support target to ES2018. Resolves #17 .
0191469 
SEE: `.browserslistrc` for details on support query.

NOTE: May change further in the future.
tmedwards added a commit that referenced this issue Dec 4, 2020
@tmedwards
UPDATE: Update browser support target to ES2020. Resolves #17 .
a3c9dd8 
Screw it.  I want the nullish coalescing and optional chaining operators, and ES2020 will be old hat by the time v3 is out anyway.

SEE: `.browserslistrc` for details on support query.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmedwards tmedwards

Labels
done Issue is resolved enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmedwards @greyelf