Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client is not fetching missing messages #71

Open
dilshansdoq opened this issue Jun 14, 2023 · 4 comments
Open

Client is not fetching missing messages #71

dilshansdoq opened this issue Jun 14, 2023 · 4 comments

Comments

@dilshansdoq
Copy link
Contributor

dilshansdoq commented Jun 14, 2023

Describe the bug
Client (i.e. SDK) is not fetching messages which are missing. Take this example. A and B have p2p topic. Both have seen upto 50 seqid. A goes offline (or even left this p2p topic, just so A is not acknowledging B's messages). B sends 50 messages to A. A subscribes to topic and ask for data from server. get:what:data:since=50,limit=24. Server will send 24 messages from 100-76. A's view is full. Now A scrolls to see earlier messages. Range 75-51 is missing. SDK doesn't call server to fetch those messages.

To Reproduce
Steps to reproduce the behavior:

  1. Login with two users A and B such that they are upto x seqid.
  2. A goes offline. B sends 50 messages such that latest seqid is x+50.
  3. A comes online. A will see latest n messages i.e. x+50-n to x+50.
  4. A scrolls to see more messages. A cannot see x to x+50-n messages. These are missing

Expected behavior
No messages should be missing unless and until deleted from server.

Screenshots
Sender:
image
Receiver(missing messages):
Screenshot from 2023-06-15 01-18-24

Environment (please complete the following information):

  • OS: Linux
  • Browser Chrome/Edge
  • SDK Version 0.22.8

Console log
missing-messages.zip

Additional context
This gets solved, if A clears its cache. Now all messages are fetched with page size.

@or-else
Copy link
Contributor

or-else commented Jun 14, 2023

I this is fixed in 0.23.

@dilshansdoq
Copy link
Contributor Author

dilshansdoq commented Jun 14, 2023

Cool. Is this change committed? I couldn't find. Could you please send it.

@or-else
Copy link
Contributor

or-else commented Jun 14, 2023

It's one of the million changes that were committed to 23. It's the changes related to pinning messages and the message gaps.

@or-else
Copy link
Contributor

or-else commented Jun 14, 2023

It's in the next branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants