Skip to content

Fix data flow during fit_transform #1075

Open
alex-hse-repository opened this issue Jan 19, 2023 · 0 comments
Open

Fix data flow during fit_transform #1075

alex-hse-repository opened this issue Jan 19, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@alex-hse-repository
Copy link
Collaborator

🚀 Feature Request

The current version of data flow during fit_transform is not optimal, it might be improved.

Proposal

  1. In to_pandas method:
  • Add flag copy:bool=True, implement the corresponding logic
  • Remove segments from slices
  1. In BaseTransform class:
  • Method fit should request the reference to the full df
  • Methods transform/inverse_transform should request the copy of the df with required features

Test cases

  1. Test that flag copy works, get the dataframe, change it and compare with dataframe in dataset
  2. Fix tests for BaseTransform if nessesary

Additional context

No response

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Specification
Development

No branches or pull requests

1 participant