Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle more WhereWhen time co-ordinate systems. #2

Open
timstaley opened this issue Oct 31, 2016 · 0 comments
Open

Handle more WhereWhen time co-ordinate systems. #2

timstaley opened this issue Oct 31, 2016 · 0 comments

Comments

@timstaley
Copy link
Owner

timstaley commented Oct 31, 2016

Currently we blindly accept the following co-ord system tags, and assume they are similar enough not to warrant conversion:

vp.definitions.sky_coord_system.utc_fk5_geo,
vp.definitions.sky_coord_system.utc_fk5_topo,
vp.definitions.sky_coord_system.utc_icrs_geo,
vp.definitions.sky_coord_system.utc_icrs_topo,

Essentially, if the timestamp isn't UTC, we ignore the WhereWhen section and drop the 'coords' table entry.
It shouldn't be too hard to implement conversion from all the time-system options (GPS, TDB, TT) to UTC using the astropy routines. Likewise it may be worth converting from FK5 to ICRS where appropriate for the sake of logical consistency, although the actual difference is small (<80mas).
We currently do not store a 'geo/topo/bary' (reference frame centre) field. Might consider adding this in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant