-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web] Themes are not propagating properly when providers are in separate files #81
Comments
I have previously raised a similar issue, and for clarity, I am providing the link to it. |
@hdwatts This is a bug that affects Tamagui so we should track your issue tamagui/tamagui#1718 and tamagui/tamagui#1319. The real bug for t4-app is that the bottom sheet doesn't change color t4-theme-toggle-demo.mp4@timothymiller I can commit this theme toggle component if that's something we want out of the box. |
@albbus-stack I love the theme toggle let's add it! |
Re: the original issue, I've tested this on native & web, and the issue only seems to persist on web. FWIW |
Dude, the issue was the dependency array was incomplete. Biome lint helped uncover the issue. Total cringe bro. |
Seems like this issue has resurfaced |
I've opened a Tamagui issue here: tamagui/tamagui#1718
And a reproduction repo here: https://github.com/hdwatts/tamagui-playground
The repro isn't a t4-app, but I confirmed that adding switches and the theme toggle to the home screen in a fresh t4-app will lead to this same issue.
For now I may recommend combining the theme/tamagui providers and can open a PR if you agree.
The text was updated successfully, but these errors were encountered: