-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tobs version telemetry is capturing Promscale version #537
Comments
Since 12.0.0 is out now and we don't have CLI application, we can consider refactoring telemetry. It means we should fix issue reported here as well as in #467 while still keeping relevant datapoints. Considering that we heavily changed tobs release process and we are on the way to do the same for promscale helm chart, the question is if we do still see any value in having helm chart version sent via telemetry? Would it maybe make more sense to ship only the following datapoints and correlate the data during analysis:
With such dataset we can see if tobs is adopted, if it is updated (by seeing if promscale is updated), which features are used, etc. From an engineering perspective, it would be relevant to know the following:
Either way if we require sending tobs helm chart version, then this fix might be a bit more complicated as apparently, subcharts do not have access to parent chart variables. |
Currently, the recorded helm chart version is the Promscale version. We need to capture the Tobs version for the below reasons:
We cannot rely on the version of Promscale to track back Tobs version as the releases are not tied to each other and as Tobs now is a separate product itself having its own version in telemetry offers better visibility. Regarding data points and correlating the data during analysis:
I agree we need these data points:
I like all additional feedback shared for telemetry (noted for telemetry enhancements). But adding to that we definitely need Tobs version in telemetry. Maybe we can achieve this by adding it the actual value in Tobs |
Yes, correct. The question was if tobs version is useful at all considering we are releasing few times a week. If it is useful, could you tell how?
What supportability matrix? If you mean this then IMHO more informative would be to track kube version instead of tobs version.
I am under impression that we don't have enough granularity in those. For example there is no distinction between installing via plain manifests vs helm chart. Also we need to refactor this mechanism to satisfy #467 |
I agree on telemetry for manifests vs helm. We need some flag to capture manifest-based installation but that falls under Promscale repo. So let's discuss telemetry specific to the Promscale manifest file in the Promscale repo. Now we are able to already capture: Promscale helm-based install, Tobs helm-based install, and Tobs CLI-based install. |
With the new release process, there is no data to back this up. We will be releasing major versions every time there is a breaking change. For example 13.0.0 is just around the corner with #546 and we released 12.0.0 just ~10 days ago.
Yes, but this causes issues on tobs side (#467) and thus needs refactoring. So we can use this time to make it much better not just slightly better. |
What happened?
The version telemetry shared by Tobs is not the version of Tobs helm chart. We are capturing the Promscale helm chart version as the env
value: "{{ .Chart.Version }}"
set in Promscale env and it's capturing the version specific to Promscale helm chart.Did you expect to see something different?
The Promscale version is already captured in Promscale telemetry. I expect to see Tobs version here.
How to reproduce it (as minimally and precisely as possible):
Installing the Tobs and verifying in the Promscale telemetry table shows the version as the Promscale version.
Anything else we need to know?:
At the moment our telemetry with this datapoint isn't right as its Promscale version and of almost zero value to us.
The text was updated successfully, but these errors were encountered: