Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve contributor guidelines #31

Open
jiri-janousek opened this issue Aug 17, 2018 · 1 comment
Open

Improve contributor guidelines #31

jiri-janousek opened this issue Aug 17, 2018 · 1 comment
Labels
type: quality Improves quality of the app or the user experience.

Comments

@jiri-janousek
Copy link
Member

Some ideas:

  • Don't make pull requests from your master branch. Always create an aptly-named feature branch and use it to create a pull request. The name of the branch should reference an issue, e.g., fix-123, or should relate to the content of the pull request, e.g., waf-update, whitespace-fixes, docs-update, etc.
  • Never mix unrelated changes in a single pull request, but create one pull request for each kind of changes. An example of unrelated changes is "Update bundled waf" + "Fix whitespace" + "Port wscript's compatibility with Python 3.7".
@jiri-janousek
Copy link
Member Author

Hm, diorite has no CONTRIBUTING.md!

@jiri-janousek jiri-janousek mentioned this issue Aug 24, 2018
Closed
@jiri-janousek jiri-janousek added type: quality Improves quality of the app or the user experience. status: backlog labels Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: quality Improves quality of the app or the user experience.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jiri-janousek