Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref should be dropped in favor only of network and shield_text #1027

Open
nvkelso opened this issue Sep 8, 2016 · 7 comments
Open

Ref should be dropped in favor only of network and shield_text #1027

nvkelso opened this issue Sep 8, 2016 · 7 comments

Comments

@nvkelso
Copy link
Member

nvkelso commented Sep 8, 2016

Now that we're relying on network and shield_text (see #966) to do the heavy lifting instead of ref, we should probably drop ref from low- and mid-zooms (or maybe entirely) and modify merge logic to use the shield bits instead.

Probably only the singular network and shield_text at zooms 0-8 and at 9+ all_networks and all_shield_texts.

Example:

# Way: I 81 (302933871)
# http://www.openstreetmap.org/way/302933871
# Example tile: `14, 4496, 6381` in **roads** layer.
@nvkelso nvkelso added this to the v1.0.0 milestone Sep 8, 2016
@nvkelso nvkelso changed the title Ref should be dropped at early zooms Ref should be dropped, merging should be based on network and shield_text Sep 8, 2016
@nvkelso
Copy link
Member Author

nvkelso commented Sep 8, 2016

  • What map location are you having problems with? near 10/36.9543/-81.0022 in tile 10/281/398
  • Screenshot?

image

type: "MultiLineString",
properties: {
kind: "highway",
network: "US:I",
sort_key: 383,
kind_detail: "motorway",
source: "openstreetmap.org",
all_networks: [
"US:I",
"US:US"
],
shield_text: "81",
ref: "I 81;US 11",
id: 172243650,
all_shield_texts: [
"81",
"11"
]

(ignore the sidewalk bit in the screenshot)

@nvkelso
Copy link
Member Author

nvkelso commented Sep 8, 2016

In that same tile, here's a counter example where the ref contains data the network and shield_text lack:

properties: {
kind: "major_road",
network: "US:US",
sort_key: 380,
kind_detail: "primary",
source: "openstreetmap.org",
shield_text: "21",
ref: "US 21;US 52"
},

@nvkelso
Copy link
Member Author

nvkelso commented Sep 8, 2016

There's so many roads that only have ref values and no network relations in Europe we shouldn't do this in v1.

@nvkelso nvkelso modified the milestones: v1.1.0, v1.0.0 Sep 8, 2016
@nvkelso nvkelso modified the milestones: v1.2.0, v1.1.0 Oct 5, 2016
@nvkelso nvkelso changed the title Ref should be dropped, merging should be based on network and shield_text Ref should be dropped, road merging should be based on network and shield_text Oct 5, 2016
@nvkelso
Copy link
Member Author

nvkelso commented Apr 7, 2017

If tile file size is an issue after #1172 let's pull this one into v1.1 milestone.

@nvkelso nvkelso modified the milestones: v1.2.0, v1.3.0 Apr 7, 2017
@nvkelso
Copy link
Member Author

nvkelso commented May 4, 2017

We can't drop ref entirely (that'd be a 2.0 breaking change), but the rest of the description is still valid.

@zerebubuth
Copy link
Member

It looks like we already drop ref on kinds:

  • major_road between zooms 0 and 6 inclusive,
  • minor_road between zooms 0 and 13 inclusive,
  • rail between zooms 0 and 14 inclusive,
  • path between zooms 0 and 11 inclusive.

Is that good enough for now? Or shall we try pushing the major_road zoom level down to 9 or something?

@nvkelso
Copy link
Member Author

nvkelso commented Dec 5, 2018

Doesn't seem like much of an issue. Let's address this in v2.0 when we strip off ref entirely in favor of network and shield_text.

@nvkelso nvkelso changed the title Ref should be dropped, road merging should be based on network and shield_text Ref should be dropped in favor only of network and shield_text Dec 5, 2018
@nvkelso nvkelso modified the milestones: v1.6.0, v2.0.0 Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants